-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(how-to): Measure maximum latency #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add cyclictest examples * add histogram plot example Signed-off-by: Lincoln Wallace <[email protected]>
lblythen
approved these changes
Feb 26, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Lincoln Wallace <[email protected]>
fd496cd
to
31b8f7a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Lincoln Wallace <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
* add command output * add instruction to install gnuplot * add script to plot on doc to have more control on it Signed-off-by: Lincoln Wallace <[email protected]>
lblythen
approved these changes
Feb 27, 2024
Co-authored-by: Lloyd Blythen <[email protected]>
Co-authored-by: Lloyd Blythen <[email protected]>
Co-authored-by: Lloyd Blythen <[email protected]>
Signed-off-by: Lincoln Wallace <[email protected]>
farshidtz
requested changes
Feb 28, 2024
farshidtz
reviewed
Feb 28, 2024
farshidtz
reviewed
Feb 28, 2024
Co-authored-by: Farshid Tavakolizadeh <[email protected]>
Co-authored-by: Farshid Tavakolizadeh <[email protected]>
Co-authored-by: Farshid Tavakolizadeh <[email protected]>
Signed-off-by: Lincoln Wallace <[email protected]>
* Uses the same machine for all console outputs * Add explanation on actions performed by script Signed-off-by: Lincoln Wallace <[email protected]>
Signed-off-by: Lincoln Wallace <[email protected]>
790a255
to
57383b0
Compare
farshidtz
reviewed
Feb 29, 2024
* use duration on histogram script * add tab to show difference on outputs with and without rt * add note with command on importance of loaded system when testing Signed-off-by: Lincoln Wallace <[email protected]>
locnnil
commented
Feb 29, 2024
farshidtz
reviewed
Mar 1, 2024
Co-authored-by: Farshid Tavakolizadeh <[email protected]>
Co-authored-by: Farshid Tavakolizadeh <[email protected]>
Co-authored-by: Farshid Tavakolizadeh <[email protected]>
* use only one machine * add tabs to example results Signed-off-by: Lincoln Wallace <[email protected]>
364e803
to
74d311f
Compare
farshidtz
requested changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I appreciate the changes.
There are just a couple of minor issues related to the script and its citation.
Co-authored-by: Farshid Tavakolizadeh <[email protected]>
Co-authored-by: Farshid Tavakolizadeh <[email protected]>
Co-authored-by: Farshid Tavakolizadeh <[email protected]>
Signed-off-by: Lincoln Wallace <[email protected]>
farshidtz
approved these changes
Mar 5, 2024
EdoardoBarbieriCanonical
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTD preview