Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-6431] Reformat the charm.py #22

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[DPE-6431] Reformat the charm.py #22

wants to merge 5 commits into from

Conversation

phvalguima
Copy link
Collaborator

This PR breaks the charm.py file into its constituent parts for events/ and managers/.

deusebio
deusebio previously approved these changes Feb 17, 2025
View reviewed changes
Copy link

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I really like the new charm.py file now :D It is a lot shorter and clearer, I believe. Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deusebio deusebio deusebio left review comments

@marcoppenheimer marcoppenheimer Awaiting requested review from marcoppenheimer

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phvalguima @deusebio