-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-6296] Pyright fixes + structured_config additions + break down of actions.py #13
[DPE-6296] Pyright fixes + structured_config additions + break down of actions.py #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the private methods, classes, etc in lifecycle.py
seems to be a bit un-pythoinic, but this is more a suggestion than a strong comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is miles easier to review, FANTASTIC work! Approving as most of it is fixes. What's up with the check_libraries
CI step failing?
This PR brings multiple pyright fixes and adds structured_config as a model to deconflict type checks.
This PR is a replacement of: #7
All its comments should be addressed.