Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-6296] Pyright fixes + structured_config additions + break down of actions.py #13

Merged
merged 23 commits into from
Jan 22, 2025

Conversation

phvalguima
Copy link
Collaborator

This PR brings multiple pyright fixes and adds structured_config as a model to deconflict type checks.

This PR is a replacement of: #7
All its comments should be addressed.

deusebio
deusebio previously approved these changes Jan 17, 2025
Copy link

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the private methods, classes, etc in lifecycle.py seems to be a bit un-pythoinic, but this is more a suggestion than a strong comment.

@phvalguima phvalguima changed the base branch from DPE-6296-add-libs to main January 17, 2025 18:33
@phvalguima phvalguima dismissed deusebio’s stale review January 17, 2025 18:33

The base branch was changed.

Copy link

@marcoppenheimer marcoppenheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is miles easier to review, FANTASTIC work! Approving as most of it is fixes. What's up with the check_libraries CI step failing?

@phvalguima phvalguima merged commit 69f7982 into main Jan 22, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants