-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for IOMMU config (New) #1715
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1715 +/- ##
==========================================
+ Coverage 49.12% 49.19% +0.06%
==========================================
Files 372 373 +1
Lines 40338 40392 +54
Branches 6809 6821 +12
==========================================
+ Hits 19816 19869 +53
Misses 19799 19799
- Partials 723 724 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
97a33b9
to
25f884b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call on creating an attachment to have a copy of the kernel config in each submission.
I've provided a few comments inline. I think Checkbox resource jobs can be used to skip the job instead of running it when not needed.
print( | ||
"Skipping: kernel version" | ||
" {} is lower than {}.".format(kernel_version, min_version) | ||
) | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't Checkbox mechanism be used to skip the job instead of passing the job with a "skipping..." comment?
To do this, you can use the uname
resource job that would contain the version number, for instance. Then you could use this as a requirement (uname.release >= "6.8.0-20"
) to decide whether or not to skip the job.
if "arm" in line: | ||
print("Skipping: arm architecture detected.") | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, you could use the cpuinfo.platform
resource information to skip if not x86_64
.
WARNING: This modifies com.canonical.certification::sru-server
Description
We want to check if the
CONFIG_INTEL_IOMMU_DEFAULT_ON
config flag is present in versions of the kernel >=6.8.0-20Note: I've included the test into the submission-cert-automated test-plan. It's already being run in all of the devices and it includes also some info tests, so it made sense for me to include it here. Let me know if you think it should be in another test-plan
Note: I had to remove the config iterator (see commit: removed iterator for python 3.5). I don't like this too much, but the unit tests failed in python 3.5 if I read the file line by line.
Resolved issues
https://warthogs.atlassian.net/browse/CHECKBOX-1608
Documentation
Tests
Tested with:
classic image, ubuntu 24, kernel "6.8.0-52-generic"
core image, ubuntu 24, pc-kernel "6.11.0-17-generic"
https://certification.canonical.com/hardware/201805-26252/submission/410961/test-results/
core image, ubuntu 22, pc-kernel "5.15.0-132-generic"
https://certification.canonical.com/hardware/201802-26085/submission/410964/test-results/
core image, ubuntu 22, pc-kernel "5.15.0-132-generic"
https://certification.canonical.com/hardware/201802-26085/submission/410964/test-results/
core image, ubuntu 24, pi-kernel "6.8.0-1016-raspi" (ARM)
https://certification.canonical.com/hardware/202310-32203/submission/411376/test-results/