Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed requirement of udisks2 on core (BugFix) #1212

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

fernando79513
Copy link
Collaborator

Description

Acording to #1029, the test was failing on some ubuntu core devices, because they required having the udisks2 snap, but the udisks2 snap was not needed for devices that run ubuntu core, since they were using another script to test the USB.
In summary:

  • The removable_storage_watcher.py wouldn't work on core even if udisks2 snap is installed
  • The run_watcher.py wouldn't work on some desktop devices
  • On core devices, since they are using run_watcher.py, we do not require udisks2 snaps

Resolved issues

#1029, https://warthogs.atlassian.net/browse/CHECKBOX-1279

Documentation

There are no documentation changes.

Tests

When running:

checkbox.checkbox-cli run com.canonical.certification::usb/insert

Ubuntu Desktop requires the udisks2 package or the udisks2 snap, and fails if they don't exist
Ubuntu Core does not require this check.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.32%. Comparing base (9318a5c) to head (2820a6a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1212   +/-   ##
=======================================
  Coverage   43.32%   43.32%           
=======================================
  Files         356      356           
  Lines       38658    38658           
  Branches     6559     6559           
=======================================
  Hits        16750    16750           
  Misses      21245    21245           
  Partials      663      663           
Flag Coverage Δ
provider-base 16.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? is an empty requires constraint valid?

Copy link
Collaborator

@Hook25 Hook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yessir it does, +1

you learn something new every day out here :)

@Hook25 Hook25 merged commit 0a8f61d into main Apr 29, 2024
15 checks passed
@Hook25 Hook25 deleted the fix-usb-insert-test-on-core branch April 29, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants