-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Included firmware revision and hw revision for wwan resource job (Bugfix) #1168
Conversation
3b64a8a
to
e4d431f
Compare
e24696a
to
2e462c3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1168 +/- ##
==========================================
+ Coverage 43.21% 43.44% +0.22%
==========================================
Files 356 356
Lines 38662 38674 +12
Branches 6561 6561
==========================================
+ Hits 16706 16800 +94
+ Misses 21293 21211 -82
Partials 663 663
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this!
I left a comment inline, because I think the unit tests are a bit convoluted. I propose another method.
included fw and hw revision for wwan resource job
fixed the test failed issue on CI environment
fixed unittest failed on python3.5 issue
fixed unit tests
fixed black coding style issue
2a7fc75
to
eb16794
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the mocking in the test is broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM
Description
We would like to collect the firmware revision and hardware revision in the wwan resource job, so we could have the enough information to identify any regression issues related WWAN device.
Resolved issues
N/A
Documentation
N/A
Tests
Tested on one x86 platform running server image