Add template_id to the Checkbox submission JSON schema (infra) #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on checkbox.json update done in #1107.
pieqq
changed the title
mz2
requested changes
Apr 18, 2024
There was a problem hiding this comment.
As instructed in another presently opened PR the reference documentation for the schema is not automatically generated on schema changes.
I'd like to request one of two possible sets of changes:
- Execute the reference documentation generating script and commit the changes it made to version control.
- Do what's in option (1) and introduce a CI task that executes the schema generating script and compares the result against the version committed in version control. Fail if different, succeed if the same. This is how we ensure in case of https://github.com/canonical/hardware-api that the OpenAPI schema checked into version control is up to date, for example.
fernando79513
added
the
waiting-for-changes
|
Closing as it was solved in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on checkbox.json update done in #1107.
Resolved issues
Documentation
Tests