Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance spectation #229

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Enhance spectation #229

merged 3 commits into from
Jan 19, 2025

Conversation

IsaacThoman
Copy link
Member

@IsaacThoman IsaacThoman commented Jan 18, 2025 •
edited
Loading

  • updated healthIndicator to show the player you're spectating's health rather than health of localPlayer
  • updated inventory to show item spectated player is holding (added fields to Player for states like isShooting and rightClickHeld for rendering)

@IsaacThoman IsaacThoman marked this pull request as ready for review January 18, 2025 02:28
@IsaacThoman IsaacThoman changed the title Enhancement spectation Enhance spectation Jan 18, 2025
@IsaacThoman IsaacThoman linked an issue Jan 18, 2025 that may be closed by this pull request
Spectator mode improvements #210
Closed
3 tasks
@IsaacThoman IsaacThoman merged commit e4b39ed into dev Jan 19, 2025
8 checks passed
@IsaacThoman IsaacThoman deleted the enhancement-spectation branch January 19, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinJMann AustinJMann AustinJMann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spectator mode improvements
2 participants
@IsaacThoman @AustinJMann