Move compile-time dependencies to dependencies in package.json
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmv08
changed the title
dependencies in package.jsondependencies in package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CandideWallet contracts import contracts from AA, OpenZeppelin and Safe contracts packages, but those packages are only marked as a development dependency therefore if someone wants to build on top of Candide Contracts, compiling the contracts will fail since the dependencies won't be present in the dependency tree (devDeps of dependencies are not installed)
This PR fixes the issue by moving the "compile" time dependencies from
devDependenciestodependencies