[POC} Only load media segments for Representations known to be decipherable #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
force-pushed
the
poc/load-media-segments-only-decipherable
branch
5 times, most recently
from
ca58e14 to
b87ca86
Compare
…erable Historically, the RxPlayer load media segments and perform the license-fetching logic in parallel, as it theoretically lead to faster playback when all qualities are decipherable. However, this has always only been a theory and it may have the reverse effect on devices whose some keys are not obtainable (this also is only theoretical). To better know what the impact of loading media segments in parallel or after the license, I'm here only loading media segments (not the initialization segment, which can be loaded right away) either if the Representation is clear or is known to be decipherable. This is only a Proof-Of-Concept with for now no intent to make it a feature.
peaBerberian
force-pushed
the
poc/load-media-segments-only-decipherable
branch
from
b87ca86 to
29e3541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, the RxPlayer load media segments and perform the license-fetching logic in parallel, as it theoretically lead to faster playback when all qualities are decipherable.
However, this has always only been a theory and it may have the reverse effect on devices where we're not able to obtain all keys (this also is only theoretical).
To better know what the impact of loading media segments in parallel or after the license, I'm here only loading media segments (not the initialization segment, which can be loaded right away) either if the Representation is clear or is known to be decipherable.
This is only a Proof-Of-Concept with for now no intent to make it a feature.