Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps(wildfly): upgrade to wildfly 35 #4863

Merged
merged 5 commits into from
Jan 21, 2025
Merged

deps(wildfly): upgrade to wildfly 35 #4863

merged 5 commits into from
Jan 21, 2025

Conversation

PHWaechtler
Copy link
Contributor

@PHWaechtler PHWaechtler commented Dec 19, 2024 •
edited
Loading

related to #4655

Description

Adds support for wildfly 35

Keeping track of license check in this doc

  • License check doc here (ignore checkboxes in license bot list)
  • Manual testing of CE Wildfly 35
  • Manual testing of EE Wildfly 35
  • Manual testing of EE Jboss 8
  • CI green

For manual testing setup, this guide was used.
Follow up: https://github.com/camunda/team-automation-platform/issues/282

@PHWaechtler PHWaechtler self-assigned this Dec 19, 2024
@PHWaechtler PHWaechtler added ci:jbosseap Runs the builds for the JBoss EAP application server. ci:wildfly Runs the builds for the Wildfly application server. bot:java-dependency-check When assigned to a PR, generates SBOMs for the PR and base branch and compares them. labels Dec 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited by PHWaechtler
Loading

Java dependency diff

Omitted due to character limit. See workflow artifacts for full diff file.

Module details

Omitted due to character limit. See workflow artifacts for full diff file.

Checklist

Unique changes

Unique additions

Developer comments

Glossary

Limitations

  • The reported transitive dependencies may not always be accurate in a multi-module project.
    The SBOM file format represents a unique dependency (coordinates + type) only once. In a multi-module
    project a dependency can be declared in multiple locations with different exclusions of transitive dependencies
    or different version overrides for transitive dependencies.

Emojies

  • ✔: All licenses are on the Go list
  • ⚠: (At least one) license is on the Caution list
  • ❌: (At least one) license is on the Stop list
  • ❓: (At least one) license cannot be determined or is unknown
  • ‼: Dependency has multiple licenses declared
  • ⬆: New dependency version is higher than previous
  • ⬇: New dependency version is lower than previous
  • 🔄: Dependency version is equal and the dependencies of this component changed (e.g. when comparing snapshots)
  • 🤷: The change of the dependency version can not be determined further (e.g. because the version does not follow semantic versioning)

@PHWaechtler PHWaechtler force-pushed the 4655-support-wildfly-35 branch from a6126f2 to 8ce1d36 Compare December 20, 2024 12:53
@PHWaechtler PHWaechtler mentioned this pull request Jan 7, 2025
Open
1 task
@PHWaechtler PHWaechtler force-pushed the 4655-support-wildfly-35 branch from 802d5aa to 24bc0f2 Compare January 9, 2025 08:49
PHWaechtler
PHWaechtler commented Jan 9, 2025
View reviewed changes
Jenkinsfile Show resolved Hide resolved
@PHWaechtler PHWaechtler marked this pull request as ready for review January 9, 2025 10:12
@PHWaechtler PHWaechtler requested a review from psavidis January 13, 2025 06:15
psavidis
psavidis approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@psavidis psavidis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Highlights

  • Manual Testing
    • Wildfly Distro CE - I was able to build, start up the distro and start a process instance, observe it in cockpit etc. Everything looks standard.
    • Wildfly Distro EE - Same as above
    • JBoss EAP 8 - Same as above
  • CI
    • Cargo Maven Plugin is updated to latest version by the time of the review
      • Example in webapp-IT-wildfly-h2 stage
        • Log: [2025-01-09T09:44:35.141Z] [INFO] --- cargo-maven3-plugin:1.10.16:stop (stop-container) @ camunda-qa-integration-tests-webapps-shared-engine ---
    • webapp-IT-wildfly-h2 module now tests against the updated version wildfly version
      • Example in webapp-IT-wildfly-h2 stage
        • Log: [2025-01-09T09:44:35.343Z] [INFO] WildFly 35.0.0.Final is stopping...
  • License check looks complete and accurate to me

🚀 LGTM, good job!

@PHWaechtler PHWaechtler merged commit 166278c into master Jan 21, 2025
5 checks passed
@PHWaechtler PHWaechtler deleted the 4655-support-wildfly-35 branch January 21, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psavidis psavidis psavidis approved these changes

Assignees

@PHWaechtler PHWaechtler

Labels
bot:java-dependency-check When assigned to a PR, generates SBOMs for the PR and base branch and compares them. ci:jbosseap Runs the builds for the JBoss EAP application server. ci:wildfly Runs the builds for the Wildfly application server.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PHWaechtler @psavidis