refactor: Nullable enable and suppress warnings #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisKujawa
reviewed
Oct 29, 2024
|
|
||
| public IZeebeClientFinalBuildStep UseKeepAlive(TimeSpan keepAlive) | ||
| public ZeebePlainClientBuilder(string? address, ILoggerFactory? loggerFactory = null) |
There was a problem hiding this comment.
Can you explain why we want to make it nullable?
There was a problem hiding this comment.
I have not changed anything to the behavior of the code but just activated the nullable reference. What happens here is a good example of the benefits of nullable references: the ZeebeClientBuilder can indeed call the ZeebePlainClientBuilder with both arguments null. This is just a constatation and the current behavior. Indeed not what is expected but then it should be changed inanother PR. At least, this current version checks correctly for nullable references when we try to access their properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.