Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed header name from scriptFormat to language #514

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Changed header name from scriptFormat to language #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0ed92d
changed from scriptFormat to language
jonathanlukas Nov 3, 2023
bc7f1f9
Adjusted failing test
jonathanlukas Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend-diagram-converter/core/src/main/resources/converter-properties.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ zeebe-header.result-variable=resultVariable
## Resource
zeebe-header.resource=resource
## Script format
zeebe-header.script-format=scriptFormat
zeebe-header.script-format=language
# Zeebe Meta Information
zeebe-platform.version=8.3
# Flags
Expand Down
2 changes: 1 addition & 1 deletion ...erter/core/src/test/java/org/camunda/community/migration/converter/BpmnConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ void testInternalScript_8_1() {
.asList()
.hasSize(4);
assertThat(result.getResult("FeelScriptTask").getMessages().get(0).getMessage())
.isEqualTo("Script format 'feel' was set to header 'scriptFormat'. Please review.");
.isEqualTo("Script format 'feel' was set to header 'language'. Please review.");
assertThat(result.getResult("FeelScriptTask").getMessages().get(1).getMessage())
.isEqualTo(
"Element 'scriptTask' was transformed. Currently, script tasks are implemented like service tasks with job type 'script'. Please review your implementation.");
Expand Down