Skip to content

Commit

Permalink
shopfloor_packing_info: deprecate
Browse files Browse the repository at this point in the history
  • Loading branch information
JuMiSanAr committed Mar 15, 2024
1 parent c114af4 commit 805be66
Show file tree
Hide file tree
Showing 8 changed files with 62 additions and 15 deletions.
9 changes: 0 additions & 9 deletions shopfloor/services/checkout.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,22 +100,13 @@ def _response_for_select_package(self, picking, lines, message=None):
data={
"selected_move_lines": self._data_for_move_lines(lines.sorted()),
"picking": self.data.picking(picking),
"packing_info": self._data_for_packing_info(picking),
"no_package_enabled": not self.options.get(
"checkout__disable_no_package"
),
},
message=message,
)

def _data_for_packing_info(self, picking):
"""Return the packing information
Intended to be extended.
"""
# TODO: This could be avoided if included in the picking parser.
return ""

def _response_for_select_dest_package(self, picking, move_lines, message=None):
packages = picking.mapped("move_line_ids.result_package_id").filtered(
"packaging_id"
Expand Down
1 change: 0 additions & 1 deletion shopfloor/tests/test_checkout_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ def _assert_select_package_qty_above(self, response, picking):
self._move_line_data(ml) for ml in picking.move_line_ids.sorted()
],
"picking": self._picking_summary_data(picking),
"packing_info": "",
"no_package_enabled": True,
},
message={
Expand Down
1 change: 0 additions & 1 deletion shopfloor/tests/test_checkout_list_delivery_packaging.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ def test_list_delivery_packaging_not_available(self):
"selected_move_lines": [
self._move_line_data(ml) for ml in selected_lines.sorted()
],
"packing_info": self.service._data_for_packing_info(self.picking),
"no_package_enabled": not self.service.options.get(
"checkout__disable_no_package"
),
Expand Down
1 change: 0 additions & 1 deletion shopfloor/tests/test_checkout_scan_package_action.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,6 @@ def test_scan_package_action_scan_package_keep_source_package_error(self):
data={
"picking": self.data.picking(picking),
"selected_move_lines": self.data.move_lines(selected_lines),
"packing_info": self.service._data_for_packing_info(picking),
"no_package_enabled": not self.service.options.get(
"checkout__disable_no_package"
),
Expand Down
1 change: 0 additions & 1 deletion shopfloor/tests/test_checkout_select_package_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ def _assert_selected_response(
self._move_line_data(ml) for ml in selected_lines.sorted()
],
"picking": self._picking_summary_data(picking),
"packing_info": packing_info,
"no_package_enabled": no_package_enabled,
},
message=message,
Expand Down
4 changes: 2 additions & 2 deletions shopfloor_packing_info/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
{
"name": "Shopfloor Packing Info",
"summary": "Allows to predefine packing information messages per partner.",
"version": "14.0.1.1.0",
"version": "14.0.1.2.0",
"development_status": "Alpha",
"category": "Inventory",
"website": "https://github.com/OCA/wms",
"author": "Camptocamp, Odoo Community Association (OCA)",
"license": "AGPL-3",
"application": False,
"depends": ["shopfloor", "sales_team"],
"depends": ["shopfloor", "sales_team", "stock_picking_partner_note"],
"data": [
"security/ir.model.access.csv",
"views/res_partner_views.xml",
Expand Down
56 changes: 56 additions & 0 deletions shopfloor_packing_info/migrations/14.0.1.2.0/post-migrate.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
# Copyright 2024 Camptocamp SA
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)

import logging

from odoo import SUPERUSER_ID, api

_logger = logging.getLogger(__name__)

# NOTE: This module is deprecated in favor of stock_picking_partner_note.
# Here, we migrate the data from shopfloor.packing.info to stock.picking.note.


def setup_stock_picking_note__packing(env):
"""Create a new packing note type named 'packing'."""

_logger.info("Create a new picking note type named 'packing'")
packing_note_type = env["stock.picking.note.type"].search(
[("name", "=", "packing")], limit=1
)
if not packing_note_type:
packing_note_type = env["stock.picking.note.type"].create({"name": "packing"})
return packing_note_type


def populate_stock_picking_note__packing(env):
"""Migrate data from shopfloor.packing.info to stock.picking.note of type 'packing'.
We also update the stock_picking_note_ids of the partners
based on their existing shopfloor_packing_info_id values."""

_logger.info(
"Migrate data from shopfloor.packing.info to stock.picking.note of type 'packing'"
)
packing_note_type = setup_stock_picking_note__packing(env)
existing_packing_infos = env["shopfloor.packing.info"].search([])
for packing_info in existing_packing_infos:
note = env["stock.picking.note"].create(
{
"name": packing_info.text,
"note_type_id": packing_note_type.id,
}
)
partner = env["res.partner"].search(
[("shopfloor_packing_info_id", "=", packing_info.id)], limit=1
)
if partner:
partner.stock_picking_note_ids |= note


def migrate(cr, version):
if not version:
return

env = api.Environment(cr, SUPERUSER_ID, {})
populate_stock_picking_note__packing(env)
4 changes: 4 additions & 0 deletions shopfloor_packing_info/readme/DESCRIPTION.rst
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
DEPRECATED: This module is deprecated in favor of stock_picking_partner_note,
which is now used in shopfloor to display notes in the app.


Adds the option to choose predefined messages for the
parameter "Checkout Packing Info", that is set on Customers
and reused in other places, mainly pickings. These new messages
Expand Down

0 comments on commit 805be66

Please sign in to comment.