[FIX] pylint

camptocamp · May 2, 2024 · 2005d1e · 2005d1e
1 parent bf7b62e
commit 2005d1e
Show file tree

Hide file tree

Showing 11 changed files with 130 additions and 110 deletions.
diff --git a/shopfloor/actions/change_package_lot.py b/shopfloor/actions/change_package_lot.py
@@ -90,8 +90,10 @@ def _change_pack_lot_change_lot(
                 move_line.location_id,
                 move_line.product_id,
                 lot=lot,
-                name=_("Pick: stock issue on lot: {} found in {}").format(
-                    lot.name, move_line.location_id.name
+                name=_(
+                    "Pick: stock issue on lot: %(lot_name)s found in %(location_name)s",
+                    lot_name=lot.name,
+                    location_name=move_line.location_id.name,
                 ),
             )
             message = self.msg_store.cannot_change_lot_already_picked(lot)

diff --git a/shopfloor/actions/completion_info.py b/shopfloor/actions/completion_info.py
@@ -34,10 +34,9 @@ def popup(self, move_lines):
             return None
         return {
             "body": _(
-                "Last operation of transfer {}. "
-                "Next operation ({}) is ready to proceed."
-            ).format(
-                ", ".join(pickings.mapped("name")),
-                ", ".join(next_pickings.mapped("name")),
+                "Last operation of transfer %(picking_names)s. "
+                "Next operation (%(next_picking_names)s) is ready to proceed.",
+                picking_names=", ".join(pickings.mapped("name")),
+                next_picking_names=", ".join(next_pickings.mapped("name")),
             )
         }
diff --git a/shopfloor/actions/message.py b/shopfloor/actions/message.py
@@ -112,9 +112,9 @@ def package_different_change(self):
     def package_not_available_in_picking(self, package, picking):
         return {
             "message_type": "warning",
-            "body": _("Package {} is not available in transfer {}.").format(
-                package.name, picking.name
-            ),
+            "body": _(
+                "Package %(package_name)s is not available in transfer %(picking_name)s."
+            ).format(package.name, picking.name),
         }
 
     def package_not_empty(self, package):
@@ -352,8 +352,11 @@ def package_change_error_same_package(self, package):
     def x_units_put_in_package(self, qty, product, package):
         return {
             "message_type": "success",
-            "body": _("{} {} put in {}").format(
-                qty, product.display_name, package.name
+            "body": _(
+                "%(qty)s %(product_name)s put in %(package_name)s",
+                qty=qty,
+                product_name=product.display_name,
+                package_name=package.name,
             ),
         }
 
@@ -536,9 +539,9 @@ def location_content_transfer_item_complete(self, location_dest):
     def location_content_transfer_complete(self, location_src, location_dest):
         return {
             "message_type": "success",
-            "body": _("Content transferred from {} to {}.").format(
-                location_src.name, location_dest.name
-            ),
+            "body": _(
+                "Content transferred from %(location_name)s to %(location_dest_name)s."
+            ).format(location_src.name, location_dest.name),
         }
 
     def location_content_unable_to_transfer(self, location_dest):
@@ -686,23 +689,28 @@ def unable_to_pick_more(self, quantity):
     def lot_replaced_by_lot(self, old_lot, new_lot):
         return {
             "message_type": "success",
-            "body": _("Lot {} replaced by lot {}.").format(old_lot.name, new_lot.name),
+            "body": _("Lot %(old_lot_name)s replaced by lot %(new_lot_name)s.").format(
+                old_lot.name, new_lot.name
+            ),
         }
 
     def package_replaced_by_package(self, old_package, new_package):
         return {
             "message_type": "success",
-            "body": _("Package {} replaced by package {}.").format(
-                old_package.name, new_package.name
-            ),
+            "body": _(
+                "Package %(old_package_name)s replaced by package %(new_package_name)s."
+            ).format(old_package.name, new_package.name),
         }
 
     def package_already_picked_by(self, package, picking):
         return {
             "message_type": "error",
             "body": _(
-                "Package {} cannot be picked, already moved by transfer {}."
-            ).format(package.name, picking.name),
+                "Package %(package_name)s cannot be picked, already moved "
+                "by transfer %(picking_name)s.",
+                package_name=package.name,
+                picking_name=picking.name,
+            ),
         }
 
     def units_replaced_by_package(self, new_package):
@@ -714,7 +722,11 @@ def units_replaced_by_package(self, new_package):
     def package_change_error(self, package, error_msg):
         return {
             "message_type": "error",
-            "body": _("Package {} cannot be used: {} ").format(package.name, error_msg),
+            "body": _(
+                "Package %(package_name)s cannot be used: %(error)s",
+                package_name=package.name,
+                error=error_msg,
+            ),
         }
 
     def cannot_change_lot_already_picked(self, lot):
@@ -764,8 +776,11 @@ def package_open(self):
     def packaging_invalid_for_carrier(self, packaging, carrier):
         return {
             "message_type": "error",
-            "body": _("Packaging '{}' is not allowed for carrier {}.").format(
-                packaging.name if packaging else _("No value"), carrier.name
+            "body": _(
+                "Packaging '%(package_name)s' is not allowed for carrier "
+                "%(carrier_name)s.or carrier %(carrier_name)s.",
+                package_name=packaging.name if packaging else _("No value"),
+                carrier_name=carrier.name,
             ),
         }
 

diff --git a/shopfloor/i18n/ca.po b/shopfloor/i18n/ca.po
@@ -277,7 +277,7 @@ msgstr "Transferència de contingut a {} competada"
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "Content transferred from {} to {}."
+msgid "Content transferred from %(location_name)s to %(location_dest_name)s."
 msgstr "Contingut transferit de {} a {}."
 
 #. module: shopfloor
@@ -459,7 +459,7 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/completion_info.py:0
 #, python-format
-msgid "Last operation of transfer {}. Next operation ({}) is ready to proceed."
+msgid "Last operation of transfer %(picking_names)s. Next operation (%(next_picking_names)s) is ready to "
 msgstr ""
 
 #. module: shopfloor
@@ -538,7 +538,7 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "Lot {} replaced by lot {}."
+msgid "Lot %(old_lot_name)s replaced by lot %(new_lot_name)s."
 msgstr ""
 
 #. module: shopfloor
@@ -816,13 +816,13 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "Package {} cannot be picked, already moved by transfer {}."
+msgid "Package %(package_name)s cannot be picked, already moved by transfer %(picking_name)s."
 msgstr ""
 
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "Package {} cannot be used: {} "
+msgid "Package %(package_name)s cannot be used: %(error)s"
 msgstr ""
 
 #. module: shopfloor
@@ -853,7 +853,7 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "Package {} is not available in transfer {}."
+msgid "Package %(package_name)s is not available in transfer %(picking_name)s."
 msgstr ""
 
 #. module: shopfloor
@@ -871,7 +871,7 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "Package {} replaced by package {}."
+msgid "Package %(old_package_name)s replaced by package %(new_package_name)s."
 msgstr ""
 
 #. module: shopfloor
@@ -882,7 +882,7 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "Packaging '{}' is not allowed for carrier {}."
+msgid "Packaging '%(package_name)s' is not allowed for carrier %(carrier_name)s."
 msgstr ""
 
 #. module: shopfloor
@@ -918,7 +918,7 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/change_package_lot.py:0
 #, python-format
-msgid "Pick: stock issue on lot: {} found in {}"
+msgid "Pick: stock issue on lot: %(lot_name)s found in %(location_name)s"
 msgstr ""
 
 #. module: shopfloor
@@ -1115,9 +1115,9 @@ msgstr ""
 #: code:addons/shopfloor/models/shopfloor_menu.py:0
 #, python-format
 msgid ""
-"Scenario `{}` require(s) 'Move Entire Packages' to be enabled.\n"
+"Scenario `%(scenario_name)s` require(s) 'Move Entire Packages' to be enabled.\n"
 "These type(s) do not satisfy this constraint: \n"
-"{}.\n"
+"%(bad_picking_types)s.\n"
 "Please, adjust your configuration."
 msgstr ""
 
@@ -1791,7 +1791,7 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "{} {} put in {}"
+msgid "%(qty)s %(product_name)s put in %(package_name)s"
 msgstr ""
 
 #~ msgid ""

diff --git a/shopfloor/i18n/de.po b/shopfloor/i18n/de.po
@@ -275,7 +275,7 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "Content transferred from {} to {}."
+msgid "Content transferred from %(location_name)s to %(location_dest_name)s."
 msgstr ""
 
 #. module: shopfloor
@@ -455,7 +455,7 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/completion_info.py:0
 #, python-format
-msgid "Last operation of transfer {}. Next operation ({}) is ready to proceed."
+msgid "Last operation of transfer %(picking_names)s. Next operation (%(next_picking_names)s) is ready to "
 msgstr ""
 
 #. module: shopfloor
@@ -534,7 +534,7 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "Lot {} replaced by lot {}."
+msgid "Lot %(old_lot_name)s replaced by lot %(new_lot_name)s."
 msgstr ""
 
 #. module: shopfloor
@@ -812,20 +812,20 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "Package {} cannot be picked, already moved by transfer {}."
+msgid "Package %(package_name)s cannot be picked, already moved by transfer %(picking_name)s."
 msgstr ""
 
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "Package {} cannot be used: {} "
+msgid "Package %(package_name)s cannot be used: %(error)s"
 msgstr ""
 
 #. module: shopfloor
 #: code:addons/shopfloor/models/stock_move_line.py:0
 #, python-format
 msgid ""
-"Package {} does not contain available product {}, cannot replace package."
+"Package %(package_name)s does not contain available product %(product_name)s, cannot replace package."
 msgstr ""
 
 #. module: shopfloor
@@ -849,7 +849,7 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "Package {} is not available in transfer {}."
+msgid "Package %(package_name)s is not available in transfer %(picking_name)s."
 msgstr ""
 
 #. module: shopfloor
@@ -867,7 +867,7 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "Package {} replaced by package {}."
+msgid "Package %(old_package_name)s replaced by package %(new_package_name)s."
 msgstr ""
 
 #. module: shopfloor
@@ -878,7 +878,7 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "Packaging '{}' is not allowed for carrier {}."
+msgid "Packaging '%(package_name)s' is not allowed for carrier %(carrier_name)s."
 msgstr ""
 
 #. module: shopfloor
@@ -914,7 +914,7 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/change_package_lot.py:0
 #, python-format
-msgid "Pick: stock issue on lot: {} found in {}"
+msgid "Pick: stock issue on lot: %(lot_name)s found in %(location_name)s"
 msgstr ""
 
 #. module: shopfloor
@@ -1111,9 +1111,9 @@ msgstr ""
 #: code:addons/shopfloor/models/shopfloor_menu.py:0
 #, python-format
 msgid ""
-"Scenario `{}` require(s) 'Move Entire Packages' to be enabled.\n"
+"Scenario `%(scenario_name)s` require(s) 'Move Entire Packages' to be enabled.\n"
 "These type(s) do not satisfy this constraint: \n"
-"{}.\n"
+"%(bad_picking_types)s.\n"
 "Please, adjust your configuration."
 msgstr ""
 
@@ -1787,5 +1787,5 @@ msgstr ""
 #. module: shopfloor
 #: code:addons/shopfloor/actions/message.py:0
 #, python-format
-msgid "{} {} put in {}"
+msgid "%(qty)s %(product_name)s put in %(package_name)s"
 msgstr ""