Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(grafana-eventhandler): add affinity parameter to the Helm template #98

Merged
merged 4 commits into from
Mar 13, 2024
Merged

feat(grafana-eventhandler): add affinity parameter to the Helm template #98

merged 4 commits into from
Mar 13, 2024

Conversation

omohammed95
Copy link
Contributor

@omohammed95 omohammed95 commented Sep 20, 2023 •
edited by lentidas
Loading

Description of the changes

This PR to set and expose affinity for eventHandler instances.

Breaking change

  • No

@omohammed95 omohammed95 requested a review from a team as a code owner September 20, 2023 16:02
@omohammed95 omohammed95 self-assigned this Sep 21, 2023
lentidas
lentidas previously approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@lentidas lentidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good do me, I've just made a few comments that I just would like clarified.

Also, I changed the title of the PR to be more descriptive on the changelog.

locals.tf Show resolved Hide resolved
@lentidas lentidas changed the title feat(loki-stack): add affinity parameter to enventHandler feat(grafana-eventhandler): add affinity parameter to the Helm template Sep 21, 2023
@lentidas lentidas requested a review from a team September 21, 2023 11:14
@lentidas lentidas marked this pull request as draft November 13, 2023 10:08
@omohammed95 omohammed95 marked this pull request as ready for review March 12, 2024 15:36
@omohammed95 omohammed95 merged commit 776c5db into main Mar 13, 2024
@omohammed95 omohammed95 deleted the ISDEVOPS-252-set-affinity-parameter branch March 13, 2024 15:25
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentidas lentidas lentidas approved these changes

Assignees

@omohammed95 omohammed95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omohammed95 @lentidas