Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks)!: add option to create IAM role for the metrics storage #112

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

lentidas
Copy link
Contributor

@lentidas lentidas commented Apr 16, 2024

Description of the changes

This commit solves ISDEVOPS-279 and ISDEVOPS-283 for the EKS variant. That is, it adds support for creating the IAM role automatically inside the modules while also giving the chance to provide a custom one managed by the user.

⚠️ Do a Rebase and merge

Breaking change

  • Yes - because the Terraform variable was changed

Tests executed on which distribution(s)

  • EKS (AWS)

@lentidas lentidas requested a review from a team as a code owner April 16, 2024 15:45
@lentidas lentidas self-assigned this Apr 16, 2024
This commit solves ISDEVOPS-279 and ISDEVOPS-283 for the EKS variants.
@lentidas lentidas changed the title feat(eks): add option to create IAM role for the metrics storage feat(eks)!: add option to create IAM role for the metrics storage Apr 19, 2024
Copy link
Member

@ckaenzig ckaenzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, except I think we could avoid making this a breaking change by giving the create_role argument a default value false.

eks/extra-variables.tf Show resolved Hide resolved
@lentidas lentidas merged commit 9ca0950 into main Apr 23, 2024
@lentidas lentidas deleted the ISDEVOPS-279 branch April 23, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants