Skip to content

Commit

Permalink
fix: remove the working_directory attribute in the compactor config
Browse files Browse the repository at this point in the history
This [flag](grafana/helm-charts@824e3da#diff-c09523f8c89a2fdb980fa9bb57eebcbb45a5950391a6bb8d44b549ea184388f6) was hardcoded before and was removed on the version 0.79.x of the chart. As a consequence, it seems that the attribute `compactor.working_directory' was taking its place and breaking our deployments. As a fix, I've decided to revert to the default configuration which uses the `/var/loki` directory (which is mounted as a persistent volume created automatically, as defined by our values).
  • Loading branch information
lentidas committed Aug 14, 2024
1 parent d325189 commit 0638108
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
3 changes: 1 addition & 2 deletions aks/locals.tf
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ locals {
}
structuredConfig = {
compactor = {
shared_store = "azure"
working_directory = "/var/loki"
shared_store = "azure"
}
}
})
Expand Down
3 changes: 1 addition & 2 deletions eks/locals.tf
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ locals {
}
structuredConfig = {
compactor = {
working_directory = "/data/compactor"
shared_store = "s3"
shared_store = "s3"
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions kind/locals.tf
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ locals {
}
structuredConfig = {
compactor = {
working_directory = "/data/compactor"
shared_store = "aws"
shared_store = "aws"
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions sks/locals.tf
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ locals {
}
structuredConfig = {
compactor = {
working_directory = "/data/compactor"
shared_store = "s3"
shared_store = "s3"
}
}
}
Expand Down

0 comments on commit 0638108

Please sign in to comment.