Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove the Helm diff #94

Merged
merged 2 commits into from
Nov 3, 2023
Merged

fix!: remove the Helm diff #94

merged 2 commits into from
Nov 3, 2023

Conversation

lentidas
Copy link
Contributor

@lentidas lentidas commented Oct 16, 2023

Description of the changes

This feature was controversial within the team and for that reason a variable to activate was added before. However, this feature was not propagated to the other modules, so we decided as a team to remove it altogether for consistency between modules.

Breaking change

  • Yes (in the module itself): removed no longer used Terraform variable

Tests executed on which distribution(s)

  • EKS (AWS)

@lentidas lentidas self-assigned this Oct 16, 2023
@lentidas lentidas marked this pull request as ready for review October 16, 2023 15:13
@lentidas lentidas requested a review from a team as a code owner October 16, 2023 15:13
jbarascut
jbarascut previously approved these changes Oct 19, 2023
This feature was controversial within the team and for that reason a variable to activate was added before. However, this feature was not propagated to the other modules, so we decided as a team to remove it altogether for consistency between modules.
@lentidas lentidas force-pushed the ISDEVOPS-251-remove-Helm-diff branch from a907520 to af81c2c Compare November 3, 2023 10:44
@lentidas lentidas merged commit 65fb62b into main Nov 3, 2023
@lentidas lentidas deleted the ISDEVOPS-251-remove-Helm-diff branch November 3, 2023 10:54
@github-actions github-actions bot mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants