fix: remove the need to set the Let's Encrypt e-mail when self-signed #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lentidas
force-pushed
the
fix_letsencrypt_email
branch
from
8022413 to
1b034d3
Compare
lentidas
force-pushed
the
fix_letsencrypt_email
branch
from
66cd395 to
8334318
Compare
jbarascut
approved these changes
Nov 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
The last PR added the
letsencrypt_issuer_emailas a required variable, which is correct on every variant except the self-signed one, which does not use Let´s Encrypt. This PR solves that.Breaking change