Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common artifact for device test scenarios #400

Merged
merged 8 commits into from
Jan 31, 2025

Conversation

jlurien
Copy link
Collaborator

@jlurien jlurien commented Jan 21, 2025

What type of PR is this?

  • enhancement/feature
  • tests

What this PR does / why we need it:

Error scenarios for device management are designed in a new artifact in Commonalities, that can be reused. This deprecates previous scenarios testing the same aspects.

README has been updated, removing some technical debt that has been resolved

Which issue(s) this PR fixes:

Fixes #398

Special notes for reviewers:

To be updated also with outcome of #399

Changelog input

Error handling for device management updated to latest guidelines

@hdamker
Copy link
Collaborator

hdamker commented Jan 24, 2025

Fixes #398, #399

@jlurien: I don't see how this PR fixes #399

@jlurien
Copy link
Collaborator Author

jlurien commented Jan 24, 2025

Fixes #398, #399

@jlurien: I don't see how this PR fixes #399

It does not. Idea was to update it with the outcome of the discussion but it has nor progressed. So, in case that we have to align it, we'll have to create a new one. I will update the description

@hdamker
Copy link
Collaborator

hdamker commented Jan 24, 2025

"Should sinkCredential be returned as part of SessionInfo and ProvisioningInfo responses?" to be checked regarding Commonalities discussion about it.

@rartych
Copy link
Contributor

rartych commented Jan 24, 2025

"Should sinkCredential be returned as part of SessionInfo and ProvisioningInfo responses?" to be checked regarding Commonalities discussion about it.

The sinkCredential must not be present in POST and GET responses.

https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#subscriptions-data-model

Copy link
Collaborator

@eric-murray eric-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a few typos in test names, and removed the question "Should sinkCredential be returned as part of SessionInfo and ProvisioningInfo responses?" from the README, but otherwise LGTM

#399 will be resolved by #410 and not this PR

@hdamker
Copy link
Collaborator

hdamker commented Jan 31, 2025

We are ready here ... see also #410 (comment)

@hdamker hdamker merged commit 36fc7de into camaraproject:main Jan 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spring25 Issue in scope of Spring25 meta-release cycle
Projects
None yet
4 participants