-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error responses and test cases to comply with Commonalities 0.5.0 #391
Update error responses and test cases to comply with Commonalities 0.5.0 #391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @eric-murray
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
further changes looking good as well, thanks for taking also #394
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see if 401 AUTHENTICATION_REQUIRED is also deprecated. But we can create a new PR for the latest changes in Commonalities
@eric-murray Ready to merge here ... further changes coming from Commonalities (in their release candidate) can go into a new PR. |
OK, now merged |
What type of PR is this?
What this PR does / why we need it:
Commonalities 0.5.0-alpha.1 updates the error response codes associated with device handling.
This PR:
403 INVALID_TOKEN_CONTEXT
error from the OAS definitionsinfo.description
text on device object handling in each OAS definitiondate-time
examples are enclosed by quotation marksWhich issue(s) this PR fixes:
Fixes #390, #392, #389, #394
Special notes for reviewers:
None
Changelog input
Additional documentation
None