Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge discovery APIs enhancements #326

Open
wants to merge 8 commits into
base: Edge-Discovery-Service-API
Choose a base branch
from

Conversation

kohlian18
Copy link

What type of PR is this?

  • enhancement/feature
  • cleanup
  • Documentation

What this PR does / why we need it:

This segregates and simplifies edge cloud zone and application endpoint discovery APIs:

  • GET edge cloud regions API to fetch edge cloud region id and name required for discovery APIs.
  • POST method containing standardised device information schema along with application profile id for edge cloud zone discovery.
  • POST method along with device information with application endpoint ids and edge cloud regions for application endpoint discovery.
  • added information for access and authorisation token

The Edge Discovery API is designed to help users discover the most optimal
edge cloud zones for their applications. This API allows users to find the
best regions and zones for their edge cloud applications, discover optimal
edge cloud zones for deployed applications, and find the best application
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this intent "discover optimal edge cloud zones for deployed applications" is valid for the end users which would connect with the edge applications instances. In that case we need to possibly indicate the different type of users who may consume these APIs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved. Added two scenarios for api usage: Edge Cloud Zone Discovery and Application Endpoint Discovery

- Discover optimal application endpoints for client connections for deployed applications.

## Usage
Users can utilize this API to enhance the performance and connectivity of
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is bit confusing when it says the users can use this API to enhance connectivity and performance by selecting suitable edge cloud zone and application endpoints. In my view the app providers may need to use this API to deploy applications while the end users may use it just to discover application endpoints to connect with.
So in terms of the usage it would be good to describe the scenario where the given intents are to be used by the intended users as per the goals of the API. Thoughts?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

their applications by selecting the most suitable edge cloud zones and
application endpoints.

## Use Cases
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the use cases described here it seems to propose two category of users that is app developers and client applications. If this is correct how does API assumes the authorization for these users interactions with API?

@JoseMConde
Copy link
Collaborator

Should we update the name to Optimal Edge Discovery as we agreed in the last meeting??

@kohlian18
Copy link
Author

Should we update the name to Optimal Edge Discovery as we agreed in the last meeting??

Sure, i will update it and push the changes.

@JoseMConde
Copy link
Collaborator

Trying to see the API in a more generic view, I have some concerns:

  1. The first point is that I still thinking that the methods should be Get not Post. The approach is almost the same than the Get/Edcloudzones that we have in EAM and also in AED, we can have a Get with some parameters inside the request body and some of them could be required and some of them not.
  2. Another point is that Post/Edge-cloud-zones, doesn't have the same approach than Get/Edgecloudzones that we actually have in EAM. I think is interesting that the developer could filter by status. Also the ApplicationProfileId is a mandatory parameter, but maybe someone doesn't use Application Endpoint Registration and doesn't have this parameter or they use it for some Applications and for others they don't.
  3. Analizing the behaviour of POST/app-endpoints in this API and the behaviour of Application Endpoint Discovery, could be almost the same, the only thing taht is different is that we use AppId to know wich is the Application that we need the endpoint and this API uses ApplicationEndpointsId, am I wright or I am missing something??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants