Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geofencing-subscriptions for Spring25 #284

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

maxl2287
Copy link
Contributor

@maxl2287 maxl2287 commented Jan 6, 2025

What type of PR is this?

  • enhancement/feature

What this PR does / why we need it:

Updates location-verification API with the changes derived from Commonalities and ICM updates
x-camara-guidelines: 0.5.0

Which issue(s) this PR fixes:

Fixes #276

Special notes for reviewers:

There are still some open discussions in Commonalities that may impact this PR, so we will keep it open until there is a final version for x-camara-guidelines: 0.5.0

Changelog input

* Error schemas updated with enums
* Some error status and codes have been updated
* Add a note that initial events will be counted when subscriptionMaxEvents is combined with initialEvent=true

@maxl2287 maxl2287 added enhancement New feature or request Spring25 labels Jan 6, 2025
@maxl2287 maxl2287 self-assigned this Jan 6, 2025
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxl2287

Few comments - mot of them related to the PR361 of commonalities (which is not yet merged but hope soon to be):

  • 429 is not required for GET & DELETE (as described here).
  • It probably misses an example for 401: AUTHENTICATION_REQUIRED - look the PR361
  • For 422 we have to align the code value with the PR361 also - like IDENTIFIER_MISMATCH instead of DEVICE_IDENTIFIERS_MISMATCH, SERVICE_NOT_APPLICABLE instead of DEVICE_NOT_APPLICABLE
  • I guess the 422 UNNECESSARY_IDENTIFIER, MISSING_IDENTIFIER & UNSUPPORTED_IDENTIFIER examples must be added.

@maxl2287 maxl2287 requested a review from bigludo7 January 8, 2025 09:42
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Max

LGTM

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Spring25
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Alignement with Commonalities
2 participants