-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update geofencing-subscriptions for Spring25 #284
base: main
Are you sure you want to change the base?
Update geofencing-subscriptions for Spring25 #284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maxl2287
Few comments - mot of them related to the PR361 of commonalities (which is not yet merged but hope soon to be):
- 429 is not required for GET & DELETE (as described here).
- It probably misses an example for 401: AUTHENTICATION_REQUIRED - look the PR361
- For 422 we have to align the code value with the PR361 also - like IDENTIFIER_MISMATCH instead of DEVICE_IDENTIFIERS_MISMATCH, SERVICE_NOT_APPLICABLE instead of DEVICE_NOT_APPLICABLE
- I guess the 422 UNNECESSARY_IDENTIFIER, MISSING_IDENTIFIER & UNSUPPORTED_IDENTIFIER examples must be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Max
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
What this PR does / why we need it:
Updates location-verification API with the changes derived from Commonalities and ICM updates
x-camara-guidelines: 0.5.0
Which issue(s) this PR fixes:
Fixes #276
Special notes for reviewers:
There are still some open discussions in Commonalities that may impact this PR, so we will keep it open until there is a final version for x-camara-guidelines: 0.5.0
Changelog input