Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Win-vs64 stack overflow. #674

Closed
NQNStudios opened this issue Mar 3, 2025 · 1 comment
Closed

Win-vs64 stack overflow. #674

NQNStudios opened this issue Mar 3, 2025 · 1 comment
Labels
bug game Affects the game, as opposed to the editors important A high priority task windows Specific to Windows builds

Comments

@NQNStudios
Copy link
Collaborator

I traced the stack overflow to its source, which is the declaration of sdf_names with 350x50 std::strings. When I change the dimensions to 50x50 it works.

So we probably need to use an expanding vector for this, or a map of maps instead.
@NQNStudios NQNStudios added bug game Affects the game, as opposed to the editors important A high priority task windows Specific to Windows builds labels Mar 3, 2025
NQNStudios added a commit to NQNStudios/cboe that referenced this issue Mar 3, 2025
@NQNStudios
use nested map for SDF names to save stack space. Fix calref#674
8fc0d09 
This also fixes a bug where the wrong dimension was checked
@CelticMinstrel
Copy link
Member

CelticMinstrel commented Mar 4, 2025 •
edited
Loading

You've switched the rows and columns – there are 350 rows and 50 columns, not 50 rows and 350 columns.

EDIT: And now I checked back to the first revision of the docs, and it says the same thing – 300 wide and 10 tall. That's not the original version though. I'm not sure if I have that… and there's at least one real mechanic in the game that clearly treats the array as taller than it is wide.

@CelticMinstrel CelticMinstrel mentioned this issue Mar 4, 2025
Open
NQNStudios added a commit to NQNStudios/cboe that referenced this issue Mar 5, 2025
@NQNStudios
use nested map for SDF names to save stack space.
94c21f0 
Update semantics of the SDF array to (row, column) form to match
the picker space

Fix calref#674
NQNStudios added a commit to NQNStudios/cboe that referenced this issue Mar 5, 2025
@NQNStudios
use nested map for SDF names to save stack space.
001fae9 
Update semantics of the SDF array to (row, column) form to match
the picker space

Fix calref#674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug game Affects the game, as opposed to the editors important A high priority task windows Specific to Windows builds
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CelticMinstrel @NQNStudios