Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default no-items shop response is broken #669

Open
CelticMinstrel opened this issue Mar 1, 2025 · 5 comments
Open

Default no-items shop response is broken #669

CelticMinstrel opened this issue Mar 1, 2025 · 5 comments
Assignees
Labels
bug game Affects the game, as opposed to the editors
Milestone

Comments

@CelticMinstrel
Copy link
Member

I think we need to reconsider this, at least in the specific case of the healing shop. Right now, you can get this response even when there is someone who needs healing, just because they happen to not be the active character. Opening a blank shop where you can then switch characters and see the available options seems more correct. But on the other hand, having this default response when there really is nothing in the shop isn't a bad thing.

@CelticMinstrel CelticMinstrel added bug game Affects the game, as opposed to the editors labels Mar 1, 2025
@CelticMinstrel CelticMinstrel added this to the 2.0 milestone Mar 1, 2025
@NQNStudios
Copy link
Collaborator

NQNStudios commented Mar 1, 2025

What if the healing shop automatically switches your active character to the first one that can buy a healing item? (if the current one can't).

@CelticMinstrel
Copy link
Member Author

Hmm… I'm not sure. If the ultimate goal is to never show an empty shop, it would also have to auto-switch once that character is healed, or possibly even auto-close. It feels like that could be annoying, but it's hard to tell without actually trying it…

@NQNStudios
Copy link
Collaborator

NQNStudios commented Mar 1, 2025

What about putting the healing items for all 6 pcs in the one shop view?

Could feel weird for shops that mix healing with items. The versatility of the system is cool but tricky to design around.

@NQNStudios
Copy link
Collaborator

I'll do a PR we can try out the auto-switching way.

@NQNStudios NQNStudios self-assigned this Mar 1, 2025
@CelticMinstrel
Copy link
Member Author

What about putting the healing items for all 6 pcs in the one shop view?

No, I don't think that works…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug game Affects the game, as opposed to the editors
Projects
None yet
Development

No branches or pull requests

2 participants