Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N key not clicking "no" in confirmation #600

Closed
NQNStudios opened this issue Feb 11, 2025 · 2 comments · Fixed by #637
Closed

N key not clicking "no" in confirmation #600

NQNStudios opened this issue Feb 11, 2025 · 2 comments · Fixed by #637
Labels
bug game Affects the game, as opposed to the editors

Comments

@NQNStudios
Copy link
Collaborator

NQNStudios commented Feb 11, 2025 •
edited
Loading

The delete PC confirmation and the new death confirmation window are both responding to keyboard 'y' for yes but not 'n' for No. The dialogxml looks like both should work:

	<dialog defbtn='no'>
	<pict type='dlog' num='7' top='6' left='6'/>
	<text top='6' left='48' width='249' height='67'>
		You are about to kill your entire party.<br/>
		<br/>
		Are you sure you want to do this?
	</text>
	<button name='no' type='regular' def-key='n' top='84' left='239'>No</button>
	<button name='yes' type='regular' def-key='y' top='84' left='172'>Yes</button>
</dialog>

Maybe by being the default button, the no button's key of y is getting overridden with enter. When I would like it to respond to either one.

EDIT: Of the two, actually I think I would rather 'n' click the button than Enter. But that might vary from person to person, dialog to dialog, and based upon mood.
@NQNStudios NQNStudios added bug game Affects the game, as opposed to the editors labels Feb 11, 2025
@NQNStudios
Copy link
Collaborator Author

Maybe this can be fixed purely in the XML. A lot of these yes/no confirmation dialogs are just copy-pastes of the same XML into a new file (that's how I made the most recent new confirmation for the death action). So if I just survey each dialog with yes/no choices and decide some things on a case by case basis, maybe none of them will actually require a button to listen for more than one key.

For example, I think it makes little sense for the Enter key to ever result in an input of No. If I triggered an action, press Enter, and it doesn't happen, that's disorienting.

That doesn't necessarily mean Yes should be the default button--because on the other hand, if the action is destructive and I initiated it by accident, I don't want to stumble into accidentally confirming.

For important things like deleting the PC and killing the party, really to me it seems like Y and N should be the only keys it responds to. If the player ends up in those dialogs while running their brain on autopilot, it seems best to me that the Enter key does nothing so they will stop to read the confirmation and choose carefully.

Just brainstorming--I might change my mind completely. And it wouldn't hurt to have buttons that can listen to >1 key.

@NQNStudios
Copy link
Collaborator Author

Every yes-no confirmation dialog should have the same naming convention of its file.

Right now some of them are suffixed with -confirm and some are prefixed with confirm-. It should just be consistent.

@NQNStudios NQNStudios mentioned this issue Feb 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug game Affects the game, as opposed to the editors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Default controls keep their hotkey AND the enter key NQNStudios/cboe
1 participant
@NQNStudios