Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some graphics should not have black background #629

Closed
CelticMinstrel opened this issue Feb 18, 2025 · 2 comments
Closed

Some graphics should not have black background #629

CelticMinstrel opened this issue Feb 18, 2025 · 2 comments
Assignees
Labels
bug dialogxml Affects the dialog system

Comments

@CelticMinstrel
Copy link
Member

CelticMinstrel commented Feb 18, 2025

The item and PC graphics in the Get Items dialog are the case I noticed. There might be more.

@CelticMinstrel CelticMinstrel added bug dialogxml Affects the dialog system labels Feb 18, 2025
@NQNStudios
Copy link
Collaborator

NQNStudios commented Feb 18, 2025

	<xs:complexType name="pict">
		<xs:attribute name="name" type="xs:token"/>
		<xs:attribute name="type" use="required" type="picttype"/>
		<xs:attribute name="custom" default="false" type="bool"/>
		<xs:attribute name="scaled" default="false" type="bool"/>
		<xs:attribute name="framed" default="true" type="bool"/>
		<xs:attribute name="outline" default="inset" type="frameStyle"/>
		<xs:attribute name="size">
			<xs:simpleType>
				<xs:restriction base="xs:token">
					<xs:enumeration value="small"/>
					<xs:enumeration value="wide"/>
					<xs:enumeration value="tall"/>
					<xs:enumeration value="large"/>
				</xs:restriction>
			</xs:simpleType>
		</xs:attribute>
		<xs:attribute ref="def-key"/>
		<xs:attribute name="num" use="required" type="xs:integer"/>
		<xs:attributeGroup ref="rect-size"/>
		<xs:attributeGroup ref="position"/>
	</xs:complexType>

So, we could add background attribute to <pict> elements, which when set to transparent would skip the fill_rect() line and pass sf::BlendMode::Alpha to the draw call.

@CelticMinstrel CelticMinstrel self-assigned this Feb 27, 2025
@CelticMinstrel
Copy link
Member Author

CelticMinstrel commented Feb 27, 2025

Is anyone aware of other dialogs that shouldn't draw a background behind the icons? Maybe status icons in the spell picker? Guess I'll check that one… anything else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dialogxml Affects the dialog system
Projects
None yet
Development

No branches or pull requests

2 participants