Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might as well hide unused fields in Edit Special Node #618

Open
NQNStudios opened this issue Feb 16, 2025 · 6 comments
Open

Might as well hide unused fields in Edit Special Node #618

NQNStudios opened this issue Feb 16, 2025 · 6 comments
Assignees
Labels
enhancement scenedit Affects the scenario editor

Comments

@NQNStudios
Copy link
Collaborator

Image

For everything that's unused in the current node type, we might as well hide all the UI instead of label it Unused and showing junk values, right?

@NQNStudios NQNStudios added enhancement scenedit Affects the scenario editor labels Feb 16, 2025
@CelticMinstrel CelticMinstrel self-assigned this Feb 16, 2025
@NQNStudios
Copy link
Collaborator Author

Do the Unused ones ever change based on the values of other values WITHIN the same node type? That would make it more complicated than I'm thinking.

@CelticMinstrel
Copy link
Member

CelticMinstrel commented Feb 16, 2025

Currently no, but there are a couple nodes where the value of one field affects the meaning of another, so I was thinking of implementing something to update labels based on field values… and there are probably some where the value of a field determines whether another field is used, too.

@NQNStudios
Copy link
Collaborator Author

I can think of a case where I want to add a field that might be used or unused based on another field's value. So this hiding/unhiding should probably be able to be refreshed when any field changes, and could use the string "Unused" as the indicator to hide or show a label and its text box/button.

@CelticMinstrel
Copy link
Member

Rather than the string "Unused", I think it makes sense to use the button dictionary (see #607).

@NQNStudios
Copy link
Collaborator Author

Okay. So the button dictionary will be modifiable by the node's fields' focus handlers, then?

@CelticMinstrel
Copy link
Member

Sort of something like that, yes, though probably not actually directly modifying it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement scenedit Affects the scenario editor
Projects
None yet
Development

No branches or pull requests

2 participants