Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.boes file needs to exist to launch replay test scenario #603

Open
NQNStudios opened this issue Feb 14, 2025 · 2 comments
Open

.boes file needs to exist to launch replay test scenario #603

NQNStudios opened this issue Feb 14, 2025 · 2 comments
Labels
bug meta Related to the build system or other things other than the code replay Affects the replay system scenedit Affects the scenario editor

Comments

@NQNStudios
Copy link
Collaborator

The way we're staging new-format scenarios in the repository is in conflict with the format the game needs scenarios to be in to launch them.

Possible fixes (each with drawbacks) include:

  • What I tried to do in .boes file needs to exist to launch replay test scenario #601 (add the .boes file so the unpacked folder and packed file are both staged in the repository)
    • + Easy change to make
    • - The unpacked folder appears as a non-functional duplicate entry in the scenario picker.
    • - Not DRY: The test scenario will need to be re-packed/re-unpacked anytime it changes. It should only exist in the repo in one form.
  • Make the game able to run an unpacked scenario
    • + this will help fix a pesky limitation of the scenario editor's launch feature:
      showError("The scenario editor cannot launch an unpacked scenario directly. You'll need to re-open the scenario from its .boes archive.");
    • - This might be somewhat hard
  • Pack and copy replay test scenarios into debug builds
    • - I don't want to have to do this for Visual Studio and Xcode builds.
    • - The code will need to change to search for scenarios in the build folder that are not VoDT, ASR, or ZKR
@NQNStudios NQNStudios added bug game Affects the game, as opposed to the editors meta Related to the build system or other things other than the code replay Affects the replay system and removed game Affects the game, as opposed to the editors labels Feb 14, 2025
@NQNStudios
Copy link
Collaborator Author

I'm actually gonna remove the game tag from this because it won't affect players at all.

@CelticMinstrel CelticMinstrel added the scenedit Affects the scenario editor label Feb 15, 2025
@CelticMinstrel
Copy link
Member

Adding scenedit tag since it can affect the launch feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug meta Related to the build system or other things other than the code replay Affects the replay system scenedit Affects the scenario editor
Projects
None yet
Development

No branches or pull requests

2 participants