Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'Simulacrum' spell keeps monsters even if reloading before spell cast. #107

Closed
daerogami opened this issue Feb 15, 2018 · 4 comments
Closed
Labels
bug game Affects the game, as opposed to the editors
Milestone

Comments

@daerogami
Copy link
Contributor

Monsters also appear to transfer to other scenarios (doesn't reset after end of scenario.)


This is an item logged from the To-Do and was originally reported by (@CelticMinstrel?). If you are familiar with or can recreate this bug, please provide details here.

@CelticMinstrel CelticMinstrel added bug game Affects the game, as opposed to the editors labels Feb 16, 2018
@CelticMinstrel CelticMinstrel added this to the 2.0 milestone Feb 10, 2020
@NQNStudios
Copy link
Collaborator

NQNStudios commented Feb 26, 2025

The title is slightly incorrect. A ✅ indicates correct behavior in current master branch:

✅ Simulacrum monsters do not stay summoned when you reload prior to summoning them. They do stay when you reload a save where they already exist.

It's "Capture Soul" that keeps incorrect slot state when you reload before casting it. But actually, it doesn't keep the monsters stored, it just stores that the slots are full. You can't pick them. Now I'm not sure about this... because I see that the slot which gets filled is random.

Another bug:
❌ Because a loop variable isn't incremented, slots 2-4 will always have a pick button even when not filled. If one of 2-4 is not filled, slot 1 will not get a pick button.

When you have no monsters stored, you still get a choice dialog from Simulacrum. I think, instead, you should get a buffer message saying you need to Capture a Soul first.

@NQNStudios
Copy link
Collaborator

NQNStudios commented Feb 26, 2025

When you end a scenario, you keep your stored monsters. But in a new scenario, those indices might refer to totally different monsters, right? Seems like a bug.

Wait. It's something weirder than that. I ended VoDT with Apprentice Mage captured, re-entered VoDT, and had Townsperson captured. When I tried to summon the townsperson, the game crashed.

❌ exportSummons() keeps monsters stored, but the game crashes when I try to summon one. And the name/index might get corrupted sometimes (I observed Apprentice Mage become Townsperson after exiting scenario/saving/loading in some sequence).

@NQNStudios
Copy link
Collaborator

NQNStudios commented Feb 26, 2025

I think, because I couldn't reproduce the actual reported bug, I'll close this, and PR my fixes to the other bugs explaining them in a less cluttered thread.

@CelticMinstrel
Copy link
Member

For the record, if this were still an issue, it would be something like "did not clear the crystal array when loading a file".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug game Affects the game, as opposed to the editors
Projects
None yet
Development

No branches or pull requests

3 participants