Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed extra whitespace added when updating pyproject.toml #125

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

coordt
Copy link
Member

@coordt coordt commented Jan 13, 2024

  • Removed dotted-notation from requirements. There is an issue on how dotted-notation sets values in the TOMLkit data structure.

  • Added get_nested_value and set_nested_value as replacements for dotted-notation.

Fixes #123

- Removed dotted-notation from requirements. There is an issue on how dotted-notation sets values in the TOMLkit data structure.

- Added `get_nested_value` and `set_nested_value` as replacements for dotted-notation.
@coordt coordt linked an issue Jan 13, 2024 that may be closed by this pull request
Copy link

Version hint: patch
Current version: 0.16.1
New version (when merged): 0.16.2

Comment ID: Display the version hint-auto-generated

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee4d2f3) 92.84% compared to head (46c9c48) 93.04%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   92.84%   93.04%   +0.20%     
==========================================
  Files          19       19              
  Lines        1257     1279      +22     
  Branches      260      267       +7     
==========================================
+ Hits         1167     1190      +23     
  Misses         60       60              
+ Partials       30       29       -1     
Flag Coverage Δ
python-3.10 93.04% <100.00%> (+0.20%) ⬆️
python-3.11 93.04% <100.00%> (+0.20%) ⬆️
python-3.8 93.04% <100.00%> (+0.20%) ⬆️
python-3.9 93.04% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coordt coordt merged commit 4b5638d into master Jan 13, 2024
13 checks passed
@coordt coordt deleted the 123-fix-extra-whitespace-to-pyprojecttoml branch January 13, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bumping version adds extra whitespace to pyproject.toml
1 participant