Use logger.e instead of assert(false);

Other assert is not changed.
calcitem · Apr 21, 2024 · c45d1fb · c45d1fb
1 parent b047d00
commit c45d1fb
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 23 deletions.
diff --git a/src/ui/flutter_app/lib/game_page/services/controller/game_controller.dart b/src/ui/flutter_app/lib/game_page/services/controller/game_controller.dart
@@ -180,7 +180,6 @@ class GameController {
     if (GameController().isEngineRunning == true && isMoveNow == false) {
       // TODO: Monkey test trigger
       logger.v("$tag engineToGo() is still running, skip.");
-      //assert(false);
       return const EngineResponseSkip();
     }
 
@@ -369,7 +368,7 @@ class GameController {
         GameController().headerTipNotifier.showTip("Error: Skip"); // TODO
         break;
       default:
-        assert(false);
+        logger.e("$tag Unknown engine response type.");
         break;
     }
 

diff --git a/src/ui/flutter_app/lib/game_page/services/controller/tap_handler.dart b/src/ui/flutter_app/lib/game_page/services/controller/tap_handler.dart
@@ -47,7 +47,7 @@ class TapHandler {
     } else if (GameController().position.action == Act.remove) {
       GameController().position._removePieceForSetupPosition(sq);
     } else {
-      assert(false);
+      logger.e("$_logTag Invalid action: ${GameController().position.action}");
     }
 
     GameController().setupPositionNotifier.updateIcons();

diff --git a/src/ui/flutter_app/lib/game_page/services/engine/engine.dart b/src/ui/flutter_app/lib/game_page/services/engine/engine.dart
@@ -104,7 +104,6 @@ class Engine {
       await stopSearching();
     } else if (moveNow) {
       // TODO: Check why go here.
-      // assert(false);
       await stopSearching();
       final String? fen = _getPositionFen();
       if (fen == null) {

diff --git a/src/ui/flutter_app/lib/game_page/services/engine/ext_move.dart b/src/ui/flutter_app/lib/game_page/services/engine/ext_move.dart
@@ -73,7 +73,7 @@ class ExtMove {
         toRank = -1;
         break;
       case null:
-        assert(false);
+        logger.e("Invalid MoveType");
         toFile = -2;
         toRank = -2;
         break;
@@ -142,7 +142,7 @@ class ExtMove {
       case MoveType.none:
         return _squareToWmdNotation[to]!; // TODO: Can parse?
       case null:
-        assert(false);
+        logger.e("notation: Invalid MoveType");
         return "";
     }
   }

diff --git a/src/ui/flutter_app/lib/game_page/services/engine/position.dart b/src/ui/flutter_app/lib/game_page/services/engine/position.dart
@@ -505,7 +505,7 @@ class Position {
         // ignore: only_throw_errors
         throw const EngineNoBestMove();
       case null:
-        assert(false);
+        logger.e("Invalid MoveType");
         break;
     }
 
@@ -589,7 +589,7 @@ class Position {
 
           if (pieceToRemoveCount[PieceColor.white]! > 0 ||
               pieceToRemoveCount[PieceColor.black]! > 0) {
-            assert(false);
+            logger.e("[position] putPiece: pieceToRemoveCount is not 0.");
             return false;
           }
 
@@ -631,7 +631,7 @@ class Position {
                 _setGameOver(PieceColor.draw, GameOverReason.drawFullBoard);
                 return true;
               case null:
-                assert(false);
+                logger.e("[position] putPiece: Invalid BoardFullAction.");
                 break;
             }
           } else {
@@ -673,24 +673,24 @@ class Position {
                   logger.e(
                     "[position] putPiece: pieceInHandCount[_them] is 0.",
                   );
-                  assert(false);
                 }
                 pieceInHandCount[_them] = pieceInHandCount[_them]! - 1;
 
                 if (pieceToRemoveCount[sideToMove] == 0) {
                   logger.e(
                     "[position] putPiece: pieceToRemoveCount[sideToMove] is 0.",
                   );
-                  assert(false);
                 }
                 pieceToRemoveCount[sideToMove] =
                     pieceToRemoveCount[sideToMove]! - 1;
 
                 _updateKeyMisc();
               }
 
-              assert(pieceInHandCount[PieceColor.white]! >= 0 &&
-                  pieceInHandCount[PieceColor.black]! >= 0);
+              if (!(pieceInHandCount[PieceColor.white]! >= 0 &&
+                  pieceInHandCount[PieceColor.black]! >= 0)) {
+                logger.e("[position] putPiece: pieceInHandCount is negative.");
+              }
             }
 
             if (handlePlacingPhaseEnd() == false) {
@@ -782,7 +782,8 @@ class Position {
         break;
       case Phase.ready:
       case Phase.gameOver:
-        assert(false);
+        logger.e("[position] putPiece: Invalid phase.");
+        return false;
     }
     return true;
   }
@@ -1021,7 +1022,7 @@ class Position {
           _setGameOver(PieceColor.draw, GameOverReason.drawStalemateCondition);
           return true;
         case null:
-          assert(false);
+          logger.e("[position] _checkIfGameIsOver: Invalid StalemateAction.");
           break;
       }
     }
@@ -1067,13 +1068,13 @@ class Position {
       phase = Phase.placing;
       action = Act.place;
     } else {
-      assert(false);
+      logger.e("[position] setSideToMove: Invalid pieceInHandCount.");
     }
 
     if (pieceToRemoveCount[sideToMove]! > 0) {
       action = Act.remove;
     } else if (pieceToRemoveCount[sideToMove]! < 0) {
-      assert(false);
+      logger.e("[position] setSideToMove: Invalid pieceToRemoveCount.");
     }
   }
 
@@ -1356,7 +1357,6 @@ extension SetupPosition on Position {
       logger.e(
         "[position] copyWith: pieceOnBoardCount is less than 0.",
       );
-      assert(false);
     }
 
     pieceInHandCount[PieceColor.white] =
@@ -1369,7 +1369,6 @@ extension SetupPosition on Position {
       logger.e(
         "[position] copyWith: pieceInHandCount is less than 0.",
       );
-      assert(false);
     }
 
     pieceToRemoveCount[PieceColor.white] =
@@ -1382,7 +1381,6 @@ extension SetupPosition on Position {
       logger.e(
         "[position] copyWith: pieceToRemoveCount is less than 0.",
       );
-      assert(false);
     }
 
     isNeedStalemateRemoval = pos.isNeedStalemateRemoval;

diff --git a/src/ui/flutter_app/lib/game_page/widgets/toolbars/src/setup_position_toolbar.dart b/src/ui/flutter_app/lib/game_page/widgets/toolbars/src/setup_position_toolbar.dart
@@ -140,7 +140,7 @@ class SetupPositionToolbarState extends State<SetupPositionToolbar> {
     } else if (pieceColor == PieceColor.none) {
       newPieceColor = PieceColor.white;
     } else {
-      assert(false);
+      logger.e("Invalid pieceColor: $pieceColor");
     }
 
     if (newPieceColor == PieceColor.none) {
@@ -529,7 +529,7 @@ class SetupPositionToolbarState extends State<SetupPositionToolbar> {
           GameController().position.pieceInHandCount[PieceColor.white] = 0;
         }
       } else {
-        assert(false);
+        logger.e("Error: sideToMove is not white or black");
       }
     } else if (newPhase == Phase.moving) {
       if (DB().ruleSettings.millFormationActionInPlacingPhase ==
@@ -545,7 +545,7 @@ class SetupPositionToolbarState extends State<SetupPositionToolbar> {
             GameController().position.pieceInHandCount[PieceColor.black] = 0;
       }
     } else {
-      assert(false);
+      logger.e("Error: Invalid phase");
     }
 
     // TODO: Verify count in placing phase.