Use cakephp/database for mysql schema #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the schema reflection logic present in cakephp/database instead of having another copy of it in migrations. I've also fixed some quoting method usage and updated to php8 syntax.
markstory
force-pushed
the
mysql-schema
branch
from
414114b to
611b1b8
Compare
markstory
commented
Jan 3, 2025
| (id INT(11) NOT NULL) | ||
| ENGINE = InnoDB CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci"; | ||
| $this->adapter->execute($sql); | ||
| $this->assertTrue($this->adapter->hasTable('discouraged.naming.convention')); |
There was a problem hiding this comment.
I don't see a reason to continue supporting table names with. as they aren't well supported by cakephp/database either.
| $table->addColumn('column1', 'string'); | ||
| $table->save(); | ||
|
|
||
| $described = $this->adapter->describeTable('t'); |
There was a problem hiding this comment.
This method had no callers and is being removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the schema reflection logic present in cakephp/database instead of
having another copy of it in migrations.
I've also fixed some quoting method usage and updated to php8 syntax.
I'll split the changes for pending migrations out. The tests as written didn't run for me locally as I have a different database name. I also wanted to clean up the additional output generated by test setup.