Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glob pattern escaping. #778

Closed
wants to merge 1 commit into from
Closed

Fix glob pattern escaping. #778

wants to merge 1 commit into from

Conversation

dereuromark
Copy link
Member

The . would otherwise be "any" char afaik.

@dereuromark dereuromark added this to the 4.x (CakePHP 5) milestone Nov 29, 2024
@dereuromark
Copy link
Member Author

Windows is failing, is it possible that it behaves differently here?

@markstory
Copy link
Member

Isn't \ the directory separator in windows and not an escape char?

@dereuromark
Copy link
Member Author

dereuromark commented Nov 29, 2024

So do we just ignore it (close PR), or what do you suggest as fix?

@markstory
Copy link
Member

So do we just ignore it (close PR), or what do you suggest as fix?

I think we ignore. While . matches any character in regex, I don't think that is true for glob expressions.

@dereuromark
Copy link
Member Author

dereuromark commented Nov 30, 2024

Hm, in those cases it would work, yeah.

But we also merged https://github.com/cakephp/migrations/pull/773/files#diff-95ee3850797051650617a77bbc9cb2f047a0ce5997f32ce2582a5d9df8253fb0R74 in
and there without it it could become false positive or things maybe.
I wish there was a way to escape so it works for both.

@dereuromark dereuromark deleted the 4.x-escaping branch November 30, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants