Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e.g. of DI for commands #7953

Merged
merged 1 commit into from
Nov 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions en/development/dependency-injection.rst
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,13 @@ Command Example
::

// In src/Command/CheckUsersCommand.php
use Cake\Console\CommandFactoryInterface;

class CheckUsersCommand extends Command
{
public function __construct(public UsersService $users)
public function __construct(protected UsersService $users, ?CommandFactoryInterface $factory = null)
{
parent::__construct($factory);
}

public function execute(Arguments $args, ConsoleIo $io)
Expand All @@ -73,7 +76,8 @@ Command Example
{
$container
->add(CheckUsersCommand::class)
->addArgument(UsersService::class);
->addArgument(UsersService::class)
->addArgument(CommandFactoryInterface::class);
$container->add(UsersService::class);
}

Expand Down