Add deflate and inflate of panel content, changed gc chance from 1% t… #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o 10%, added 10% chance to vacuum when sqlite is used, added pragma commands for optimalization when using sqlite
LordSimal
reviewed
Aug 22, 2024
markstory
reviewed
Aug 22, 2024
Comment on lines
-134
to
+151
| $conn->execute('VACUUM;'); | ||
| $conn->execute(' | ||
| PRAGMA auto_vacuum = FULL; | ||
| PRAGMA journal_mode = OFF; | ||
| PRAGMA synchronous = OFF; | ||
| PRAGMA foreign_keys = OFF; | ||
| PRAGMA temp_store = MEMORY; | ||
| PRAGMA automatic_index = OFF; | ||
| '); |
There was a problem hiding this comment.
Should this only happen if the GC is going to occur?
There was a problem hiding this comment.
I think it is not needed to run everytime, so it is run when gc is ran
| PRAGMA automatic_index = OFF; | ||
| '); | ||
|
|
||
| if (!$this->shouldGcVacuum()) { |
There was a problem hiding this comment.
If we've already passed the rand to do a GC why do we need another rand to do vacuum?
There was a problem hiding this comment.
So rows are cleared more frequently, but the slow vacuum should be ran only 1% of requests (I made the check to own functions for static analysis tools and if we want to tweak the chance)
added 2 commits
August 22, 2024 17:04
…te for content loaded from resource
|
Any other issues with this? |
markstory
added a commit
that referenced
this pull request
Aug 29, 2024
We can't rely on this file being used. Instead we can log errors and let the application developer take care of removing their database file. Refs #1022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o 10%, added 10% chance to vacuum when sqlite is used, added pragma commands for optimalization when using sqlite
#1021