Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-312) Updated unit test checks to correctly identify unit test library #365

Merged
merged 4 commits into from
Sep 3, 2019

Conversation

AdmiringWorm
Copy link
Member

This fix is needed, otherwise any project created by a default Visual Studio 2015 unit test template can be detected as any type of unit testing library.

Hopefully this can be changed back when it have been fixed upstream in Cake.Incubator.

This can be tested by running cake on the project I set up specifically for finding these kind of things: https://github.com/AdmiringWorm/Cake.Recipe.Tests

fixes #312

gep13 and others added 4 commits October 31, 2016 21:09
* release/1.0.0: (360 commits)
  (maint) Change order of information logs
  (maint) Use correct version number format
  (build) Fix syntax error
  (cake-contribGH-306) Error if not using supported Cake Version
  (cake-contribGH-306) Fix integration tests
  (cake-contribGH-358) Update nuspec metadata
  (maint) Update to latest PS Bootstrapper
  (cake-contribGH-353) Change wording of notification messages
  (maint) Updated to latest Cake.Slack
  (cake-contribGH-354) Changed to parse path te libgit2 before patching
  (cake-contribGH-354) Updated to patch LibGit2Sharp.dll.config
  (cake-contribGH-337) Update NUnit.ConsoleRunner reference from 3.4.1 to 3.10.0
  (cake-contribGH-335) Update KuduSync.NET reference from 1.3.1 to 1.5.2
  (cake-contribGH-332) Update Cake.Wyam reference from 1.7.4 to 2.2.4
  (cake-contribGH-344) Update Wyam reference from 1.7.4 to 2.2.4
  (cake-contribGH-342) Update OpenCover reference from 4.6.519 to 4.7.922
  (cake-contribGH-328) Update Cake.Codecov reference from 0.4.0 to 0.5.0
  (cake-contribGH-326) Update Fixie reference from 1.0.2 to 2.0.4
  (cake-contribGH-327) Update JetBrains.ReSharper.CommandLineTools reference from 2018.2.3 to 2018.3.4
  (cake-contribGH-329) Update Cake.Issues.Reporting.Generic reference from 0.6.1 to 0.6.2
  ...
…nit test library

This fix is needed, otherwise any project created by a default
Visual Studio 2015 unit test template can be detected as any
type of unit testing library.
@AdmiringWorm AdmiringWorm changed the title (GH-312) Updated unit test checks to correctly identify unit test library [WIP] (GH-312) Updated unit test checks to correctly identify unit test library May 3, 2019
@AdmiringWorm AdmiringWorm changed the title [WIP] (GH-312) Updated unit test checks to correctly identify unit test library (GH-312) Updated unit test checks to correctly identify unit test library May 3, 2019
@gep13 gep13 merged commit 020c34f into cake-contrib:develop Sep 3, 2019
@AdmiringWorm AdmiringWorm deleted the bugfix/GH-312 branch September 4, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NUnit testing library is detected as xUnit
2 participants