Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NUnit testing library is detected as xUnit #312

Closed
AdmiringWorm opened this issue Jan 16, 2019 · 2 comments · Fixed by #365
Closed

NUnit testing library is detected as xUnit #312

AdmiringWorm opened this issue Jan 16, 2019 · 2 comments · Fixed by #365
Labels
Bug
Milestone
1.0.1

Comments

@AdmiringWorm
Copy link
Member

This suddenly just occurred on one of my libraries were I'm using NUnit as the testing framework.

Somehow, it gets detected as xUnit, which makes the build fail.

AppVeyor build: https://ci.appveyor.com/project/AdmiringWorm/faker-cs/builds/21667268
Project file: https://github.com/WormieCorp/Faker.NET.Portable/blob/develop/tests/Faker.Tests/Faker.Tests.csproj

This is with using the latest version of Cake.Recipe pushed to MyGet.
@AdmiringWorm
Copy link
Member Author

This seem to be a problem in the project itself, I'm unable to reproduce it in other projects, as such I'm closing this issue.

@AdmiringWorm AdmiringWorm reopened this May 3, 2019
@AdmiringWorm
Copy link
Member Author

Re-opening, as I believe it is related to the same issue I opened over at Cake.Incubator (The NUnit test project for the library was originally set up as a MSTest project, but changed at a later date).

cake-contrib/Cake.Incubator#112

AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue May 3, 2019
@AdmiringWorm
(cake-contribGH-312) Updated unit test checks to correctly identify u…
f12d8a6 
…nit test library

Hopefully this is only needed as a temporary fix until
it have been fixed upstream in Cake.Incubator.
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue May 3, 2019
@AdmiringWorm
(cake-contribGH-312) Updated unit test checks to correctly identify u…
020c34f 
…nit test library

This fix is needed, otherwise any project created by a default
Visual Studio 2015 unit test template can be detected as any
type of unit testing library.
@AdmiringWorm AdmiringWorm mentioned this issue May 3, 2019
Merged
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue May 4, 2019
@AdmiringWorm
Merge branch 'bugfix/cake-contribGH-312' into integration-test
1339e57
@gep13 gep13 added the Bug label Sep 3, 2019
@gep13 gep13 added this to the 1.0.1 milestone Sep 3, 2019
@gep13 gep13 closed this as completed Sep 3, 2019
gep13 added a commit that referenced this issue Sep 3, 2019
@gep13
Merge branch 'pr365' into hotfix/1.0.1
05a4784 
* pr365:
  (GH-312) Updated unit test checks to correctly identify unit test library
gep13 added a commit that referenced this issue Sep 3, 2019
@gep13
Merge branch 'hotfix/1.0.1'
81d9991 
* hotfix/1.0.1:
  (GH-312) Updated unit test checks to correctly identify unit test library
gep13 added a commit that referenced this issue Sep 3, 2019
@gep13
Merge branch 'hotfix/1.0.1' into develop
b68bb71 
* hotfix/1.0.1:
  (GH-312) Updated unit test checks to correctly identify unit test library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

(GH-312) Updated unit test checks to correctly identify unit test library AdmiringWorm/Cake.Recipe
2 participants
@gep13 @AdmiringWorm