Don't pass FileLinkSettings to issue provider (#195)

File link settings are already available in the settings property.
cake-contrib · Aug 1, 2020 · fd2ded6 · fd2ded6
1 parent bece6c4
commit fd2ded6
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/src/Cake.Issues.Testing/FakeConfigurableIssueProvider.cs b/src/Cake.Issues.Testing/FakeConfigurableIssueProvider.cs
@@ -59,7 +59,7 @@ public FakeConfigurableIssueProvider(
         public override string ProviderName => "Fake Issue Provider";
 
         /// <inheritdoc/>
-        protected override IEnumerable<IIssue> InternalReadIssues(FileLinkSettings fileLinkSettings)
+        protected override IEnumerable<IIssue> InternalReadIssues()
         {
             return this.issues;
         }

diff --git a/src/Cake.Issues.Testing/FakeIssueProvider.cs b/src/Cake.Issues.Testing/FakeIssueProvider.cs
@@ -48,7 +48,7 @@ public FakeIssueProvider(ICakeLog log, IEnumerable<IIssue> issues)
         public override string ProviderName => "Fake Issue Provider";
 
         /// <inheritdoc/>
-        protected override IEnumerable<IIssue> InternalReadIssues(FileLinkSettings fileLinkSettings)
+        protected override IEnumerable<IIssue> InternalReadIssues()
         {
             return this.issues;
         }

diff --git a/src/Cake.Issues/BaseIssueProvider.cs b/src/Cake.Issues/BaseIssueProvider.cs
@@ -25,15 +25,14 @@ public IEnumerable<IIssue> ReadIssues()
         {
             this.AssertInitialized();
 
-            return this.InternalReadIssues(this.Settings.FileLinkSettings);
+            return this.InternalReadIssues();
         }
 
         /// <summary>
         /// Gets all issues.
         /// Compared to <see cref="ReadIssues"/> it is safe to access Settings from this method.
         /// </summary>
-        /// <param name="fileLinkSettings">Settings which can be used for resolving links to source files.</param>
         /// <returns>List of issues.</returns>
-        protected abstract IEnumerable<IIssue> InternalReadIssues(FileLinkSettings fileLinkSettings);
+        protected abstract IEnumerable<IIssue> InternalReadIssues();
     }
 }
diff --git a/src/Cake.Issues/BaseMultiFormatIssueProvider.cs b/src/Cake.Issues/BaseMultiFormatIssueProvider.cs
@@ -23,7 +23,7 @@ protected BaseMultiFormatIssueProvider(ICakeLog log, TSettings settings)
         }
 
         /// <inheritdoc/>
-        protected override IEnumerable<IIssue> InternalReadIssues(FileLinkSettings fileLinkSettings)
+        protected override IEnumerable<IIssue> InternalReadIssues()
         {
             return
                 this.IssueProviderSettings.Format.ReadIssues(