Multi-Target .NET 8

cake-contrib · Dec 16, 2023 · 45ec533 · 45ec533
1 parent 081098a
commit 45ec533
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 2 deletions.
diff --git a/.appveyor.yml b/.appveyor.yml
@@ -13,6 +13,7 @@ install:
   - ps: '& "$($env:DOTNET_INSTALL_DIR)/dotnet-install.ps1" -Version 5.0.408 -InstallDir $env:DOTNET_INSTALL_DIR'
   - ps: '& "$($env:DOTNET_INSTALL_DIR)/dotnet-install.ps1" -Version 6.0.414 -InstallDir $env:DOTNET_INSTALL_DIR'
   - ps: '& "$($env:DOTNET_INSTALL_DIR)/dotnet-install.ps1" -Version 7.0.401 -InstallDir $env:DOTNET_INSTALL_DIR'
+  - ps: '& "$($env:DOTNET_INSTALL_DIR)/dotnet-install.ps1" -Version 8.0.100 -InstallDir $env:DOTNET_INSTALL_DIR'
   - ps: $env:Path = "$env:DOTNET_INSTALL_DIR;$env:Path"
   - ps: dotnet --info
 

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -18,6 +18,7 @@ jobs:
             5.x
             6.x
             7.x
+            8.x
       - name: Build
         run: .\build.ps1
         shell: powershell

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -27,5 +27,9 @@ jobs:
     inputs:
       version: '7.x'
     displayName: 'Install .NET 7'
+  - task: UseDotNet@2
+    inputs:
+      version: '8.x'
+    displayName: 'Install .NET 8'
   - powershell: ./build.ps1
     displayName: 'Cake Build'
diff --git a/nuspec/nuget/Cake.Issues.PullRequests.GitHubActions.nuspec b/nuspec/nuget/Cake.Issues.PullRequests.GitHubActions.nuspec
@@ -32,5 +32,8 @@ See the Project Site for an overview of the whole ecosystem of addins for workin
     <file src="net7.0\Cake.Issues.PullRequests.GitHubActions.dll" target="lib\net7.0" />
     <file src="net7.0\Cake.Issues.PullRequests.GitHubActions.pdb" target="lib\net7.0" />
     <file src="net7.0\Cake.Issues.PullRequests.GitHubActions.xml" target="lib\net7.0" />
+    <file src="net8.0\Cake.Issues.PullRequests.GitHubActions.dll" target="lib\net8.0" />
+    <file src="net8.0\Cake.Issues.PullRequests.GitHubActions.pdb" target="lib\net8.0" />
+    <file src="net8.0\Cake.Issues.PullRequests.GitHubActions.xml" target="lib\net8.0" />
   </files>
 </package>
diff --git a/src/Cake.Issues.PullRequests.GitHubActions/Cake.Issues.PullRequests.GitHubActions.csproj b/src/Cake.Issues.PullRequests.GitHubActions/Cake.Issues.PullRequests.GitHubActions.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
+    <TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
     <Description>Addin for writing code analyzer or linter issues to GitHub Actions</Description>
     <Authors>Pascal Berger</Authors>
     <Copyright>Copyright © Pascal Berger and contributors</Copyright>

diff --git a/src/Cake.Issues.PullRequests.GitHubActions/GitHubActionsPullRequestSystem.cs b/src/Cake.Issues.PullRequests.GitHubActions/GitHubActionsPullRequestSystem.cs
@@ -12,6 +12,7 @@
     /// </summary>
     public class GitHubActionsPullRequestSystem : BasePullRequestSystem
     {
+        private static readonly char[] Separator = ['\n'];
         private readonly GitHubActionsBuildSettings settings;
 
         /// <summary>
@@ -111,7 +112,7 @@ private void WriteIssues(IEnumerable<IIssue> issues)
                 // Commands don't support line breaks, therefore we only use the first line of the message.
                 var message =
                     issue.MessageText
-                        .Split(new[] { '\n' }, StringSplitOptions.RemoveEmptyEntries)
+                        .Split(Separator, StringSplitOptions.RemoveEmptyEntries)
                         .FirstOrDefault()
                         ?.Trim();
 

diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -0,0 +1,5 @@
+<Project>
+ <PropertyGroup>
+   <LangVersion>latest</LangVersion>
+ </PropertyGroup>
+</Project>
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,6 +18,7 @@ jobs: @@
 .x
 .x
 .x
+.x
           - name: Build
             run: .\build.ps1
             shell: powershell
@@ Expand Down @@