Another attempt to fix broken statix (fixes #508) #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as the commit doesn't make sense to me: the [`cli.toGNUCommandLine`](https://github.com/NixOS/nixpkgs/blob/13e7885af14a46620124d2eb4008dfae3e2cfdf2/lib/cli.nix#L119) does all the related boilerplate
|
Oh, the empty case was broken. But this is now equally broken for the non-empty case. We still need the reverted commit, in addition to an empty check. Maybe we should just go back to |
|
Merged #510 with the empty-case fix. We still need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of commits introduced changes in how
statixcli options are generated.Fix attempt #506 was merged however it fails to resolve the issue, also, IMHO, adding unnecessary complexity, duplicating lib.cli functionality
@sandydoo as #506 author, feel free to kindly comment if those changes are fine with you.