Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default hook package to null #426

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

sandydoo
Copy link
Member

@sandydoo sandydoo commented Apr 8, 2024

Allows creating hooks that don't depend on a package, without explicitly setting package = null;.
Also fixes the evaluation of enabledPackages when a hook doesn't have a package.

Fixes #427.

sandydoo added 2 commits April 8, 2024 12:19
Allows creating hooks that don't depend on a package without having to
explicitly set this to null.
@sandydoo
Copy link
Member Author

sandydoo commented Apr 8, 2024

Confirmed to work with devenv 1.0.3 and the repro in #427.

@sandydoo sandydoo requested a review from domenkozar April 8, 2024 12:33
@sandydoo sandydoo marked this pull request as ready for review April 8, 2024 12:33
@domenkozar domenkozar merged commit 70f5040 into master Apr 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom hooks seem broken in devenv v1.
2 participants