Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce black flags #403

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

benhiemer
Copy link
Contributor

This PR adds setting.black.flags making the black hook more configurable. Default is no flags.

All options are listed here, it is documented in the nix option.

I first thought about mirroring all options but this way is more flexible imho. My primary intention is to support --experimental-string-processing with this (which will change to --preview --enable-unstable-feature string_processing in black v24, see the change logs, another advantage of a generic flags argument). Of course, further options for specific arguments can be added later.

@domenkozar
Copy link
Member

Sorry for the mess, we revamed module structure in #397, could you port these changes over?

@benhiemer benhiemer force-pushed the feat-add-black-flags branch from f821893 to 8fc4dd7 Compare March 19, 2024 20:28
@benhiemer
Copy link
Contributor Author

No problem. I like the new options.hooks.<name>.settings. This PR should be adapted to the new structure now.

@domenkozar domenkozar merged commit 6184635 into cachix:master Mar 20, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants