git-hooks: prevent pre-commit from leaking build inputs into env #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream issue: NixOS/nixpkgs#302376
Python derivations built with
buildPythonApplicationor converted from a library withtoPythonApplicationdo not make the distinction between build- and run-time dependencies. When these packages are added topackages, theirpropagatedBuildInputsare leaked into the environment. This includes the Python interpreter and other dependencies, which may conflict with the user's configured environment.This PR symlinks the pre-commit binary to avoid bringing along all of the Python baggage with it.
Fixes #1644.