Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the logic that determines which push mode to use #178

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Clean up the logic that determines which push mode to use #178

merged 2 commits into from
Apr 4, 2024

Conversation

sandydoo
Copy link
Member

@sandydoo sandydoo commented Apr 2, 2024

  • Represented the push mode as an enum. Makes the setup and post-run much simpler.
  • Deduped the try-catch, hence the indentation change.

@sandydoo sandydoo requested a review from domenkozar April 4, 2024 06:05
@sandydoo sandydoo marked this pull request as ready for review April 4, 2024 06:05
@domenkozar domenkozar merged commit fb5cb83 into master Apr 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandydoo @domenkozar