Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schedule unpublish application forms and add logs upon failure #266

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

dominicwest
Copy link
Contributor

Noticed the scheduled job consistently fails to unpublish an application form. As this endpoint does not log anything upon exceptions thrown in certain places its impossible to be sure why, but the data looks sensible.

  • Adding a log upon any exception
  • Eagerly fetching scheme so we can grab the schemesId from the advert entity

Copy link
Contributor

@GavCookCO GavCookCO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice wee clean up as well

@dominicwest dominicwest merged commit b6e0ad9 into develop Mar 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants