FIX: [sentinel] Modify detection logic #1884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the anomaly detection strategy and configuration. The most important changes involve updating the configuration settings, modifying the detection logic, and improving the handling of historical data and notifications.
Configuration Updates:
config/sentinel.yaml
: Removed the persistence settings and added multiple new exchange strategies with consistent parameters for different symbols.Detection Logic Modifications:
pkg/ensemble/iforest/forest.go
: Removed theDetectionType
and related logic, simplified the threshold handling, and updated theOptions
struct. [1] [2] [3]Strategy Enhancements:
pkg/strategy/sentinel/strategy.go
: Updated theStrategy
struct to include new fields (Proportion
,NumSamples
), added validation for these fields, and modified theDefaults
method to set new default values. [1] [2] [3]These changes collectively improve the robustness and flexibility of the anomaly detection strategy.