FIX: fix AverageDepthPrice and add test TestPriceVolumeSlice_AverageDepthPrice #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rice thanks to @DaniilSokolyuk, this should fix #1861 see #1861
c9s
requested review from
COLDTURNIP,
huang47,
zenixls2,
ycdesu,
kbearXD,
gx578007,
narumiruna and
bailantaotao
|
Welcome back! @c9s, This pull request may get 272 BBG. |
|
cherry pick the fix from another PR |
narumiruna
approved these changes
Dec 14, 2024
|
Hi @c9s, Well done! 282 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0xa767d63cc7dd33b6ac04c6b8c2a8c986476c956236650ae391714c31464be618 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thanks to @DaniilSokolyuk, this should fix #1861
see #1861