FEATURE: add livenote support #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome back! @c9s, This pull request may get 210 BBG. |
…pkg/strategy/example
|
Re-estimated karma: this pull request may get 359 BBG |
|
Re-estimated karma: this pull request may get 550 BBG |
|
Re-estimated karma: this pull request may get 655 BBG |
c9s
changed the title
gx578007
reviewed
Nov 5, 2024
|
|
||
| for _, poster := range Notification.liveNotePosters { | ||
| if err := poster.PostLiveNote(obj); err != nil { | ||
| logrus.WithError(err).Errorf("unable to post live note: %+v", obj) |
There was a problem hiding this comment.
Will it cause too many error messages?
gx578007
reviewed
Nov 5, 2024
| @@ -66,7 +71,50 @@ func (n *Notifier) worker() { | |||
| } | |||
| } | |||
|
|
|||
| func (n *Notifier) PostLiveNote(obj livenote.Object) error { | |||
There was a problem hiding this comment.
How about making ctx as one of the input parameters?
gx578007
reviewed
Nov 5, 2024
| // PostLiveNote posts a live note to slack or other services | ||
| // The MessageID will be set after the message is posted if it's not set. | ||
| func PostLiveNote(obj livenote.Object) { | ||
| if len(Notification.liveNotePosters) == 0 { |
There was a problem hiding this comment.
Could Notification be nil?
gx578007
approved these changes
Nov 5, 2024
|
Hi @c9s, Well done! 690 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x95d6be829c5edd202cab9fc5e017712ff154f8de35068f80dd2a68ea4c105467 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.